[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] megasas: Use qemu_hw_version() instead of Q
From: |
Hannes Reinecke |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] megasas: Use qemu_hw_version() instead of QEMU_VERSION |
Date: |
Tue, 22 Sep 2015 22:21:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/22/2015 10:16 PM, Eduardo Habkost wrote:
> Guest visible data shouldn't change with a simple QEMU upgrade, so use
> qemu_hw_version() to ensure it won't change (as long as the machine
> class being used has hw_version set).
>
> Cc: Hannes Reinecke <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: address@hidden
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> hw/scsi/megasas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index a04369c..e0529b1 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -757,7 +757,7 @@ static int megasas_ctrl_get_info(MegasasState *s,
> MegasasCmd *cmd)
>
> memcpy(info.product_name, base_class->product_name, 24);
> snprintf(info.serial_number, 32, "%s", s->hba_serial);
> - snprintf(info.package_version, 0x60, "%s-QEMU", QEMU_VERSION);
> + snprintf(info.package_version, 0x60, "%s-QEMU", qemu_hw_version());
> memcpy(info.image_component[0].name, "APP", 3);
> snprintf(info.image_component[0].version, 10, "%s-QEMU",
> base_class->product_version);
>
Ah. right. Should be okay, then.
Reviewed-by: Hannes Reinecke <address@hidden>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
address@hidden +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
- [Qemu-devel] [PATCH 0/3] pc: Set hw_version on all machine classes, Eduardo Habkost, 2015/09/22
- [Qemu-devel] [PATCH 1/3] pc: Set hw_version on all machine classes, Eduardo Habkost, 2015/09/22
- [Qemu-devel] [PATCH 2/3] osdep: Rename qemu_{get, set}_version() to qemu_{, set_}hw_version(), Eduardo Habkost, 2015/09/22
- [Qemu-devel] [PATCH 3/3] megasas: Use qemu_hw_version() instead of QEMU_VERSION, Eduardo Habkost, 2015/09/22
- Re: [Qemu-devel] [PATCH 0/3] pc: Set hw_version on all machine classes, Igor Mammedov, 2015/09/23