[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/r

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/replay
Date: Wed, 23 Sep 2015 10:08:05 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 23/09/2015 09:22, Pavel Dovgaluk wrote:
> Sometimes tcg thread halts in qemu_tcg_wait_io_event function,
> waiting for any external event. Virtual clock does not run, because
> warp is not called. warp call in main_loop_wait proceeds virtual
> clock and allows tcg thread to run further.

Ok, this makes sense!

Would this work too as a replacement for this patch?


diff --git a/cpus.c b/cpus.c
index fbbd17f..9480acc 100644
--- a/cpus.c
+++ b/cpus.c
@@ -926,6 +926,7 @@ static void qemu_tcg_wait_io_event(CPUState *cpu)

     while (iothread_requesting_mutex) {
+        qemu_clock_warp(QEMU_CLOCK_VIRTUAL);
         qemu_cond_wait(&qemu_io_proceeded_cond, &qemu_global_mutex);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]