[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/16] blkverify: Convert s->test_file to BdrvCh
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/16] blkverify: Convert s->test_file to BdrvChild |
|
Date: |
Wed, 23 Sep 2015 15:01:21 +0200 |
|
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Thu 17 Sep 2015 03:48:07 PM CEST, Kevin Wolf wrote:
> @@ -151,7 +151,7 @@ static void blkverify_close(BlockDriverState *bs)
> {
> BDRVBlkverifyState *s = bs->opaque;
>
> - bdrv_unref(s->test_file);
> + bdrv_unref_child(bs, s->test_file);
> s->test_file = NULL;
> }
You are using bdrv_unref_child() here whereas in quorum you kept
bdrv_unref().
In principle both seem correct because if you don't detach the children
in the driver's close function then bdrv_close() will take care of doing
it, but is there a reason why you are using different methods?
Berto