Re: [Qemu-devel] [PATCH v11 2/7] vhost-user: add protocol feature negotiation

[Yuanhan Liu]

On Thu, Sep 24, 2015 at 01:13:24PM +0300, Marcel Apfelbaum wrote:
> >diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> >index 1d76b94..9d32d76 100644
> >--- a/hw/net/vhost_net.c
> >+++ b/hw/net/vhost_net.c
> >@@ -152,8 +152,10 @@ struct vhost_net *vhost_net_init(VhostNetOptions 
> >*options)
> >          net->dev.backend_features = qemu_has_vnet_hdr(options->net_backend)
> >              ? 0 : (1ULL << VHOST_NET_F_VIRTIO_NET_HDR);
> >          net->backend = r;
> >+        net->dev.protocol_features = 0;
> >      } else {
> >          net->dev.backend_features = 0;
> >+        net->dev.protocol_features = 0;
> >          net->backend = -1;
> >      }
> 
> Maybe protocol_features assignment should be outside the if clause.
> (assigned to 0 in both cases)

Yeah, we could do that. However, it seems that it will take more effort,
for handling patch conflicts while rebase, than it worths. Therefore
I will keep it.

        --yliu