[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 03/47] ivhsmem: read do not accept more than size
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PATCH v4 03/47] ivhsmem: read do not accept more than sizeof(long) |
Date: |
Thu, 24 Sep 2015 13:37:05 +0200 |
From: Marc-André Lureau <address@hidden>
ivshmem_read() only reads sizeof(long) from the input buffer. Accepting
more could lead to fifo8 abort() on 32bit systems if fifo is not empty.
A following patch will change the protocol to 64-bit little-endian
instead.
Signed-off-by: Marc-André Lureau <address@hidden>
---
hw/misc/ivshmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index cc76989..fb53b3f 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -272,7 +272,7 @@ static void ivshmem_receive(void *opaque, const uint8_t
*buf, int size)
static int ivshmem_can_receive(void * opaque)
{
- return 8;
+ return sizeof(long);
}
static void ivshmem_event(void *opaque, int event)
--
2.4.3
- [Qemu-devel] [PATCH v4 00/47] ivshmem improvements, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 01/47] char: add qemu_chr_free(), marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 02/47] msix: add VMSTATE_MSIX_TEST, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 03/47] ivhsmem: read do not accept more than sizeof(long),
marcandre . lureau <=
- [Qemu-devel] [PATCH v4 05/47] ivshmem: factor out the incoming fifo handling, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 04/47] ivshmem: fix number of bytes to push to fifo, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 06/47] ivshmem: remove unnecessary dup(), marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 07/47] ivshmem: remove superflous ivshmem_attr field, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 08/47] ivshmem: remove useless doorbell field, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 10/47] ivshmem: remove last exit(1), marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 09/47] ivshmem: more qdev conversion, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 11/47] ivshmem: limit maximum number of peers to G_MAXUINT16, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 12/47] ivshmem: simplify around increase_dynamic_storage(), marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 14/47] ivshmem: remove useless ivshmem_update_irq() val argument, marcandre . lureau, 2015/09/24