Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 09/22/2015 03:13 AM, Markus Armbruster wrote:
>
>>> Full list of unmaintained files now:
>> [...]
>> 
>
>> docs/bitmaps.md
>> docs/blkdebug.txt
>> docs/blkverify.txt
>
>> docs/live-block-ops.txt
>
>> docs/qcow2-cache.txt
>> docs/qdev-device-use.txt
>
>> docs/specs/qcow2.txt
>> docs/specs/qed_spec.txt
>
> Kevin, Stefan - should these be added to Block maintainers?
>
>> docs/writing-qmp-commands.txt
>
> Markus: Probably belongs to qapi.

QMP, actually.

>> include/qapi/dealloc-visitor.h
>> include/qapi/opts-visitor.h
>> include/qapi/qmp-event.h
>> include/qapi/qmp-input-visitor.h
>> include/qapi/qmp-output-visitor.h
>> include/qapi/qmp/dispatch.h
>> include/qapi/qmp/json-lexer.h
>> include/qapi/qmp/json-parser.h
>> include/qapi/qmp/json-streamer.h
>> include/qapi/qmp/qbool.h
>> include/qapi/qmp/qdict.h
>> include/qapi/qmp/qerror.h
>> include/qapi/qmp/qfloat.h
>> include/qapi/qmp/qint.h
>> include/qapi/qmp/qjson.h
>> include/qapi/qmp/qlist.h
>> include/qapi/qmp/qobject.h
>> include/qapi/qmp/qstring.h
>> include/qapi/qmp/types.h
>> include/qapi/string-input-visitor.h
>> include/qapi/string-output-visitor.h
>> include/qapi/util.h
>> include/qapi/visitor-impl.h
>> include/qapi/visitor.h
>
> Definitely belongs to qapi.

The core visitor stuff is clearly QAPI.  The QMP visitor stuff is where
QAPI and QMP overlap.  As long as they share a maintainer (currently
me), it doesn't matter much on which side of the fence we file them.

>> include/qemu/throttle.h
>
> Block?
>
>> include/qjson.h
>
> qapi?

Nope.  Belongs to qjson.c, which has nothing to do with QAPI.  It's a
(yet another) JSON writer that is currently used by migration.

Unfortunate choice of filename, because not only do qjson.[ch] exist
elsewhere already, but that qjson.c used to be right here until it got
moved elsewhere!  Results in a really confusing git-log.

Details: commit a372823 moved qjson.c to qobject/qjson.c, and commit
190c882 created it again.  Blerch.

>> tests/check-qdict.c
>> tests/check-qfloat.c
>> tests/check-qint.c
>> tests/check-qjson.c
>> tests/check-qlist.c
>
>> tests/check-qstring.c
>
> qapi?

Close: QObject.

>> tests/test-opts-visitor.c
>
>> tests/test-qmp-commands.c
>> tests/test-qmp-event.c
>> tests/test-qmp-input-strict.c
>> tests/test-qmp-input-visitor.c
>> tests/test-qmp-output-visitor.c
>
>> tests/test-string-input-visitor.c
>> tests/test-string-output-visitor.c
>
> qapi

Again, some QAPI, some QAPI/QMP.

I'll prepare patches to update MAINTAINERS for QAPI, QMP and QObject.

> Also, should we have some new group for maintainer files, for things like:
>
> .exrc
> .gitignore
> .gitmodules
> .mailmap
> .travis.yml
> CODING_STYLE
> COPYING
> COPYING.LIB
> Changelog
> HACKING
> LICENSE
> MAINTAINERS
>
> README
> VERSION
>
> scripts/get_maintainer.pl

If a maintainer steps forward.