[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 04/10] io: add qio_buffer_init
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [RfC PATCH 04/10] io: add qio_buffer_init |
Date: |
Fri, 25 Sep 2015 11:56:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Am 24.09.2015 um 10:42 schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> include/io/buffer.h | 12 ++++++++++++
> io/buffer.c | 11 +++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/include/io/buffer.h b/include/io/buffer.h
> index 2b1b261..cffad19 100644
> --- a/include/io/buffer.h
> +++ b/include/io/buffer.h
> @@ -34,12 +34,24 @@ typedef struct QIOBuffer QIOBuffer;
> */
>
> struct QIOBuffer {
> + char *name;
> size_t capacity;
> size_t offset;
> uint8_t *buffer;
> };
>
> /**
> + * qio_buffer_init:
> + * @buffer: the buffer object
> + * @name: buffer name
> + *
> + * Optionally attach a name to the buffer, to make it easier
> + * to identify in debug traces.
> + */
> +void qio_buffer_init(QIOBuffer *buffer, const char *name, ...)
> + GCC_FMT_ATTR(2, 3);
> +
> +/**
> * qio_buffer_reserve:
> * @buffer: the buffer object
> * @len: the minimum required free space
> diff --git a/io/buffer.c b/io/buffer.c
> index 6aa06e7..daa3ebf 100644
> --- a/io/buffer.c
> +++ b/io/buffer.c
> @@ -22,6 +22,15 @@
>
> #define QIO_BUFFER_MIN_INIT_SIZE 4096
>
> +void qio_buffer_init(QIOBuffer *buffer, const char *name, ...)
> +{
> + va_list ap;
> +
> + va_start(ap, name);
> + buffer->name = g_strdup_vprintf(name, ap);
> + va_end(ap);
> +}
> +
> void qio_buffer_reserve(QIOBuffer *buffer, size_t len)
> {
> if ((buffer->capacity - buffer->offset) < len) {
> @@ -49,9 +58,11 @@ void qio_buffer_reset(QIOBuffer *buffer)
> void qio_buffer_free(QIOBuffer *buffer)
> {
> g_free(buffer->buffer);
> + g_free(buffer->name);
> buffer->offset = 0;
> buffer->capacity = 0;
> buffer->buffer = NULL;
> + buffer->name = NULL;
> }
>
> void qio_buffer_append(QIOBuffer *buffer, const void *data, size_t len)
Reviewed-by: Peter Lieven <address@hidden>
- [Qemu-devel] [RfC PATCH 00/10] vnc buffer handling, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 03/10] vnc: make the Buffer capacity increase in powers of two, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 04/10] io: add qio_buffer_init, Gerd Hoffmann, 2015/09/24
- Re: [Qemu-devel] [RfC PATCH 04/10] io: add qio_buffer_init,
Peter Lieven <=
- [Qemu-devel] [RfC PATCH 01/10] io/ makefile fluff, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 06/10] io: add qio_buffer_move, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 09/10] vnc: kill jobs queue buffer, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 07/10] io: add qio_buffer tracing, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 08/10] name vnc buffers, Gerd Hoffmann, 2015/09/24