[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 00/16] Introduce I/O channels framework
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v1 00/16] Introduce I/O channels framework |
Date: |
Fri, 25 Sep 2015 12:18:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 24/09/2015 16:51, Daniel P. Berrange wrote:
> Thanks, I'd still love one or more people to do a detailed review of
> the I/O channel implementations before I think about sending a PULL
> request, since there's a fair amount of code in there....
I did a review of the file, socket, command and buffer code. I made
another small suggestion regarding error checking.
The command code could add support for shutdown by closing the parent's
end of the pipe. It can be useful to avoid deadlocks in bidirectional
pipes.
> I'm curious now as to which bit you might be refering to here :-) IIRC
> the only place I had any interaction with coroutines was the migration
> code QEMUFile implementation, where I need to yield when reads block.
I think it was NBD.
Paolo
- [Qemu-devel] [PATCH v1 03/16] sockets: allow port to be NULL when listening on IP address, (continued)
- [Qemu-devel] [PATCH v1 03/16] sockets: allow port to be NULL when listening on IP address, Daniel P. Berrange, 2015/09/18
- [Qemu-devel] [PATCH v1 01/16] sockets: add helpers for creating SocketAddress from a socket, Daniel P. Berrange, 2015/09/18
- [Qemu-devel] [PATCH v1 15/16] io: add QIOChannelCommand class, Daniel P. Berrange, 2015/09/18
- [Qemu-devel] [PATCH v1 13/16] io: add QIOChannelTLS class, Daniel P. Berrange, 2015/09/18
- [Qemu-devel] [PATCH v1 12/16] io: add QIOChannelFile class, Daniel P. Berrange, 2015/09/18
- [Qemu-devel] [PATCH v1 05/16] osdep: add qemu_fork() wrapper for safely handling signals, Daniel P. Berrange, 2015/09/18
- [Qemu-devel] [PATCH v1 02/16] sockets: move qapi_copy_SocketAddress into qemu-sockets.c, Daniel P. Berrange, 2015/09/18
- [Qemu-devel] [PATCH v1 14/16] io: add QIOChannelWebsock class, Daniel P. Berrange, 2015/09/18
- Re: [Qemu-devel] [PATCH v1 00/16] Introduce I/O channels framework, Paolo Bonzini, 2015/09/22