[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test cas
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case |
Date: |
Fri, 25 Sep 2015 08:50:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/25/2015 06:39 AM, Andreas Färber wrote:
> In addition to -42 also parse the maximum int64.
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> tests/test-string-input-visitor.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Shouldn't we also add tests of one-beyond-range, to have coverage of
expected error behavior when a number is too large in magnitude?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] visitor: Fix uint64 parsing for scsi-disk wwn, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 3/7] test-string-input-visitor: Add uint64 test, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 7/7] string-input-visitor: Use qemu_strto[u]ll(), Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case, Andreas Färber, 2015/09/25
- Re: [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case,
Eric Blake <=
- [Qemu-devel] [PATCH 1/7] string-input-visitor: Fix uint64 parsing, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 5/7] tests: Add scsi-disk test, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature, Andreas Färber, 2015/09/25