qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/7] test-string-input-visitor: Add uint64 test


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 3/7] test-string-input-visitor: Add uint64 test
Date: Fri, 25 Sep 2015 08:55:55 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 09/25/2015 06:39 AM, Andreas Färber wrote:
> Test parsing of decimal and hexadecimal uint64 numbers with most
> significient bit set.

s/significient/significant/

> 
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  tests/test-string-input-visitor.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)

It would also be nice to add tests of one-beyond-range to make sure we
are properly diagnosing range issues.  And we need to make up our mind
on whether "-1" is a parse error or accepted as a synonym for ULLONG_MAX
when doing an unsigned parse.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]