[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v4][PATCH 2/2] libxl: introduce gfx_passthru_kind
From: |
Ian Campbell |
Subject: |
Re: [Qemu-devel] [v4][PATCH 2/2] libxl: introduce gfx_passthru_kind |
Date: |
Fri, 25 Sep 2015 16:38:20 +0100 |
On Fri, 2015-09-18 at 16:30 +0800, Tiejun Chen wrote:
> Although we already have 'gfx_passthru' in b_info, this doesn't suffice
> after we want to handle IGD specifically. Now we define a new field of
> type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually
> this means we can benefit this to support other specific devices just
> by extending gfx_passthru_kind. And then we can cooperate with
> gfx_passthru to address IGD cases as follows:
>
> gfx_passthru = 0 => sets build_info.u.gfx_passthru to false
> gfx_passthru = 1 => sets build_info.u.gfx_passthru to true and
> build_info.u.gfx_passthru_kind to DEFAULT
> gfx_passthru = "igd" => sets build_info.u.gfx_passthru to true
> and build_info.u.gfx_passthru_kind to IGD
>
> Here if gfx_passthru_kind = DEFAULT, we will call
> libxl__is_igd_vga_passthru() to check if we're hitting that table to need
> to pass that option to qemu. But if gfx_passthru_kind = "igd" we always
> force to pass that.
>
> And "-gfx_passthru" is just introduced to work for qemu-xen-traditional
> so we should get this away from libxl__build_device_model_args_new() in
> the case of qemu upstream.
>
> Signed-off-by: Tiejun Chen <address@hidden>
Acked + applied both patches, thanks.
Stefano -- are the QEMU side patches in qemu-upstream-unstable.git yet? If
not I suppose this is a call/reminder to backport them from mainline or
whatever.
Ian.