[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/36] qapi: move examples to json schema
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/36] qapi: move examples to json schema |
Date: |
Fri, 25 Sep 2015 09:16:18 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/25/2015 08:03 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Clean-up qmp-commands.hx from examples.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> qapi-schema.json | 1128 +++++++++++++++-
> qapi/block-core.json | 365 +++++
> qapi/block.json | 32 +
> qapi/common.json | 32 +
> qapi/rocker.json | 43 +
> qapi/trace.json | 12 +
> qmp-commands.hx | 3617
> +-------------------------------------------------
> 7 files changed, 1625 insertions(+), 3604 deletions(-)
Mammoth patch.
I don't know if it would make sense to break it into smaller pieces (say
10 or so related commands per patch) - more emails, but each email is
more reviewable, and the review can be divided among the various
maintainers that implement those various commands.
Or even if there were an easy way to automate the diff to prove that
every example was exactly moved, regardless of whether the example is
correct.
I'm not necessarily opposed to keeping it as one big patch, just that it
is a big commitment to review. And I do like where we end up, it's just
that I'm worried about making sure we don't regress along the way
(particularly if other QMP command examples are introduced along the way
before this gets merged - we already had a recent example of a
regression in -help output for PCI devices due to text being added to
one file in parallel with another patch that moved the text between files).
Also, I'd love to see docs/qapi-code-gen.txt updated to list Example: as
a proper part of a sample qapi listing.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 15/36] monitor: register gen:false commands manually, (continued)
- [Qemu-devel] [PATCH 15/36] monitor: register gen:false commands manually, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 18/36] qapi: remove "middle" mode, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 16/36] qmp: register qapi commands (no middle mode), marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 21/36] misc: spelling, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 19/36] qmp: implement qmp_query_commands without qmp_cmds, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 05/36] qapi: move examples to json schema, marcandre . lureau, 2015/09/25
- Re: [Qemu-devel] [PATCH 05/36] qapi: move examples to json schema,
Eric Blake <=
- [Qemu-devel] [PATCH 17/36] qmp: use qmp_dispatch(), marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 23/36] qmp: use a return callback for the command reply, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 20/36] qmp: remove old qmp-commands table, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 22/36] qmp: teach qmp_dispatch() to take a pre-filled QDict, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 24/36] qmp: add QmpClient, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 26/36] qmp: check that async command have an 'id', marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 27/36] scripts: learn 'async' qapi commands, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 25/36] qmp: introduce async command type, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 28/36] scripts: ensure -async commands are declared async, marcandre . lureau, 2015/09/25