qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code
Date: Fri, 25 Sep 2015 11:53:43 -0700

On 25 September 2015 at 11:24, Programmingkid <address@hidden> wrote:

> I don't think Mac OS X adds the -psn argument anymore. It might have
> in the past, but I don't see any sign of it on Mac OS 10.6. I made
> a test program and launched it from both the terminal and the Finder.
> I didn't see the -psn argument.

Hmm, you're right. Googling suggests that the -psn argument is added
only if the program is in an 'application bundle' (ie not just a
bare executable).

So that means we can't easily distinguish being run from the GUI
vs from the command line, which means we don't have a convenient
way to check for whether we should bring up that dialog box.

I think that brings us back to somewhere near your first patch --
just remove the dialog box code. If anybody is somehow running
QEMU in an application bundle they'll let us know that it's broken,
I'm sure :-)

Sorry for all the back-and-forth on this patch. Can you send out
a v3 that goes back to that approach, please?

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]