Re: [Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

[Richard Henderson]

On 09/25/2015 02:10 PM, Aurelien Jarno wrote:
>> +        if (more)
>> +          byte |= 0x80;
> 
> You are missing braces here.

Gah.  I thought I fixed that...

> Given we save both the host and the guest PC in this structure, one
> obvious optimization would be to skip saving data for host instructions
> which can not generate exception. It means that all the TCG ops in this
> instruction do not generate exceptions either. We can easily test that
> for all TCG instructions except all by looking at the
> TCG_OPF_SIDE_EFFECTS flag. For the call op, we have to look at the
> TCG_CALL_NO_SIDE_EFFECTS flag, even if it doesn't necessary means the
> helper might generate exception.
> 
> That should significantly save space on load/store architectures. That
> said we can probably do that in a latter time.

Yes, Alex Bennee mentioned this during round 1.  I decided to not try to do
that all at once.

When we do get there, we also have to add an additional column for icount.
It's currently inferred that each entry is 1 insn.  This will expand the size
of the table in any case that every insn might raise an exception, but I expect
the normal case to be a slight decrease.



r~