[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 15/21] vhost user: add rarp sending after liv
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v5 15/21] vhost user: add rarp sending after live migration for legacy guest |
Date: |
Sun, 27 Sep 2015 20:04:33 +0200 |
hi
On Sun, Sep 27, 2015 at 5:49 PM, Thibaut Collet
<address@hidden> wrote:
> Maybe a solution like that is clearer ?
>
> -#define VHOST_USER_PROTOCOL_FEATURE_MASK 0x7ULL
> -#define VHOST_USER_PROTOCOL_F_MQ 0
> -#define VHOST_USER_PROTOCOL_F_LOG_SHMFD 1
> -#define VHOST_USER_PROTOCOL_F_RARP 2
> +typedef enum VhostUserProtocolFeature {
> +VHOST_USER_PROTOCOL_F_MQ = 0,
> +VHOST_USER_PROTOCOL_F_LOG_SHMFD = 1,
> +VHOST_USER_PROTOCOL_F_RARP = 2,
> +VHOST_USER_PROTOCOL_F_MAX
> +} VhostUserProtocolFeature ;
>
> +#define VHOST_USER_PROTOCOL_FEATURE_MASK ((1 << VHOST_USER_PROTOCOL_F_MAX) -
> 1)
I agree with that, I don't see a good reason to keep the defines.
--
Marc-André Lureau
- [Qemu-devel] [PATCH v5 13/21] net: add trace_vhost_user_event, (continued)
- [Qemu-devel] [PATCH v5 13/21] net: add trace_vhost_user_event, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 10/21] vhost: use a function for each call, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 14/21] vhost user: add support of live migration, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 16/21] vhost-user-test: move wait_for_fds() out, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 15/21] vhost user: add rarp sending after live migration for legacy guest, marcandre . lureau, 2015/09/24
[Qemu-devel] [PATCH v5 17/21] vhost-user-test: remove useless static check, marcandre . lureau, 2015/09/24
[Qemu-devel] [PATCH v5 18/21] vhost-user-test: wrap server in TestServer struct, marcandre . lureau, 2015/09/24
[Qemu-devel] [PATCH v5 19/21] vhost-user-test: learn to tweak various qemu arguments, marcandre . lureau, 2015/09/24
[Qemu-devel] [PATCH v5 21/21] vhost-user-test: check ownership during migration, marcandre . lureau, 2015/09/24
[Qemu-devel] [PATCH v5 20/21] vhost-user-test: add live-migration test, marcandre . lureau, 2015/09/24
Re: [Qemu-devel] [PATCH v5 00/21] vhost-user: add migration support, Michael S. Tsirkin, 2015/09/27