[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes |
Date: |
Mon, 28 Sep 2015 14:13:29 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/25/2015 10:30 PM, Eric Blake wrote:
> On 09/25/2015 02:08 AM, Yang Hongyang wrote:
>> This patchset addressed Markus comment on netfilter patch
>> series, most of them are comment fixes.
>>
>> It is based on jason's net tree:
>> https://github.com/jasowang/qemu/tree/net
> If that tree is not yet merged mainline, wouldn't it be better to squash
> these fixes directly into the offending patches, instead of using it as
> a followup patch?
Yes, and maybe a new version.
>
>> /*
>> - * we return size when buffer a packet, the sender will take it as
>> - * a already sent packet, so sent_cb should not be called later
>> - * FIXME: even if guest can't receive packet for some reasons. Filter
>> + * We return size when buffer a packet, the sender will take it as
>> + * a already sent packet, so sent_cb should not be called later.
> s/a already/an already/
>