[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline
From: |
Gabriel L. Somlo |
Subject: |
Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline |
Date: |
Mon, 28 Sep 2015 15:51:26 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 28, 2015 at 01:46:33PM -0600, Eric Blake wrote:
> On 09/28/2015 07:30 AM, Laszlo Ersek wrote:
>
> >>
> >> +Small enough items may be provided directly as strings on the command
> >> +line, using the syntax:
> >> +
> >> + -fw_cfg [name=]<item_name>,content=<string>
> >> +
> >
> > Please consider spelling out that these blobs will NOT be NUL-terminated
> > when viewed on the guest. (It kinda follows from all the other fw_cfg
> > things, but once we leave host-side files for qemu command line strings,
> > it might become non-obvious to users.)
>
> Or else GUARANTEE that it will be NUL-terminated (and the only way to
> get blobs that are not NUL terminated is to use files rather than content=).
I went with the first suggestion (leave out the trailing '\0' from the
blob payload, and say so in docs/specs/fw_cfg.txt) in v2 of the patch.
Do you feel strongly about including the \0 ? Otherwise, we're already
there :)
Thanks much,
--Gabriel
- [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Gabriel L. Somlo, 2015/09/26
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Laszlo Ersek, 2015/09/29
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Gabriel L. Somlo, 2015/09/29
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Eric Blake, 2015/09/29
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline,
Gabriel L. Somlo <=
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Eric Blake, 2015/09/29
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Laszlo Ersek, 2015/09/29
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Laszlo Ersek, 2015/09/29
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Gabriel L. Somlo, 2015/09/29
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Laszlo Ersek, 2015/09/29
- Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline, Gabriel L. Somlo, 2015/09/29