Re: [Qemu-devel] [PATCH v7 15/18] qapi: Share gen_err_check()

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> qapi-commands has a nice helper gen_err_check(), but did not

but does not use

> use it everywhere. In fact, using it in more places makes it
> easier to reduce the lines of code used for generating error
> checks.  This in turn will make it easier for later patches
> to consolidate another common pattern among the generators.

Does this message need updating now you're using gen_err_check() less
aggressively?

> The generated code has one less blank line in qapi-event.c
> functions, but has no semantic difference.

Is it a stylistic improvement or the opposite?

> Signed-off-by: Eric Blake <address@hidden>

Patch looks good.