[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable |
Date: |
Fri, 2 Oct 2015 15:50:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/02/15 15:40, Kevin O'Connor wrote:
> On Fri, Oct 02, 2015 at 10:09:17AM +0200, Gerd Hoffmann wrote:
>>> - read four bytes from under the fw_cfg selector QEMU_CFG_KERNEL_SIZE
>>> (0x0008),
>>> - if it is zero, return -1 --> no kernel boot requested,
>>> - if it is nonzero, return 0 --> which means "top priority".
>>>
>>> In other words, I agree with:
>>>
>>>> - option_rom[nb_option_roms].bootindex = 0;
>>>> + option_rom[nb_option_roms].bootindex = 1;
>
> The bootindex in QEMU is not visible in the firmware, so if the rest
> of patch 6 is dropped then the above should be dropped as well.
>
>> Hmm. That makes the boot order undefined for "qemu -kernel foo -device
>> virtio-blk,drive=bar,bootindex=1" when using an old seabios. I don't
>> think this is a good idea.
>
> Wouldn't that make the bootorder undefined everywhere? What does it
> mean to use -kernel and specify a bootorder?
OVMF & AAVMF look at QEMU_CFG_KERNEL_SIZE first, and process the
bootorder only after. (The kernel boot can fail due to various reasons,
after which it makes sense to start processing the bootorder fw_cfg file.)
Thanks
Laszlo
[Qemu-devel] [PATCH v4 2/7] fw_cfg DMA interface documentation, Marc Marí, 2015/10/08
[Qemu-devel] [PATCH v4 1/7] fw_cfg: document fw_cfg_modify_iXX() update functions, Marc Marí, 2015/10/08
[Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Marc Marí, 2015/10/08
- Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Laszlo Ersek, 2015/10/08
- Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Gerd Hoffmann, 2015/10/08
- Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Kevin O'Connor, 2015/10/08
- Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable,
Laszlo Ersek <=
- Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Gerd Hoffmann, 2015/10/08
- Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Daniel P. Berrange, 2015/10/08
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Kevin O'Connor, 2015/10/08
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Laszlo Ersek, 2015/10/08
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Marc Marí, 2015/10/08
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Gerd Hoffmann, 2015/10/08
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Marc Marí, 2015/10/08
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Gerd Hoffmann, 2015/10/08
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Laszlo Ersek, 2015/10/08
Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable, Gerd Hoffmann, 2015/10/08