[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init |
|
Date: |
Wed, 30 Sep 2015 15:04:12 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 30/09/2015 10:30, Thomas Huth wrote:
>> > @@ -944,7 +944,7 @@ static void tcx_initfn(Object *obj)
>> > SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
>> > TCXState *s = TCX(obj);
>> >
>> > - memory_region_init_ram(&s->rom, NULL, "tcx.prom", FCODE_MAX_ROM_SIZE,
>> > + memory_region_init_ram(&s->rom, OBJECT(s), "tcx.prom",
>> > FCODE_MAX_ROM_SIZE,
>> > &error_fatal);
> Why "OBJECT(s)" and not simply "obj" ?
No particular reason, just the way my brain worked. :)
Paolo
Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init, Markus Armbruster, 2015/10/08
[Qemu-devel] [PATCH 3/3] macio: move DBDMA_init from instance_init to realize, Paolo Bonzini, 2015/10/05