[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/16] block: Add and use bdrv_replace_in_backin
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 15/16] block: Add and use bdrv_replace_in_backing_chain() |
Date: |
Wed, 30 Sep 2015 16:50:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 17.09.2015 15:48, Kevin Wolf wrote:
> This cleans up the mess we left behind in the mirror code after the
> previous patch. Instead of using bdrv_swap(), just change pointers.
>
> The interface change of the mirror job that callers must consider is
> that after job completion, their local BDS pointers still point to the
> same node now. qemu-img must change its code accordingly (which makes it
> easier to understand); the other callers stays unchanged because after
> completion they don't do anything with the BDS, but just with the job,
> and the job is still owned by the source BDS.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 32 +++++++++++++++++++++++++++++++-
> block/mirror.c | 23 +++++++----------------
> include/block/block.h | 4 +++-
> qemu-img.c | 16 ++++++++--------
> 4 files changed, 49 insertions(+), 26 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature