|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 5/7] tcg/mips: Support r6 multiply/divide encodings |
Date: | Thu, 1 Oct 2015 09:24:17 +1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 10/01/2015 01:30 AM, James Hogan wrote:
case INDEX_op_mul_i32: + if (use_mips32r6_instructions) { + tcg_out_opc_reg(s, OPC_MUL_R6, a0, a1, a2); + break; + } if (use_mips32_instructions) { tcg_out_opc_reg(s, OPC_MUL, a0, a1, a2); break;
I wonder if it's worth defining a common OPC_MUL as you did with OPC_JR. Also, these columns aren't lining up. Did you use tabs? r~
[Prev in Thread] | Current Thread | [Next in Thread] |