[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/11] virtio-gpu: move iov free to virtio_gpu_cleanu
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov |
Date: |
Fri, 9 Oct 2015 10:18:27 +0200 |
For symmetry reasons: virtio_gpu_create_mapping_iov() allocates it so
virtio_gpu_cleanup_mapping_iov() should free it, otherwise it's easy to
miss a free() needed and leak memory.
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
hw/display/virtio-gpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index a67d927..73bd9b6 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -563,7 +563,6 @@ int virtio_gpu_create_mapping_iov(struct
virtio_gpu_resource_attach_backing *ab,
__func__, ab->resource_id, i);
virtio_gpu_cleanup_mapping_iov(*iov, i);
g_free(ents);
- g_free(*iov);
*iov = NULL;
return -1;
}
@@ -580,12 +579,12 @@ void virtio_gpu_cleanup_mapping_iov(struct iovec *iov,
uint32_t count)
cpu_physical_memory_unmap(iov[i].iov_base, iov[i].iov_len, 1,
iov[i].iov_len);
}
+ g_free(iov);
}
static void virtio_gpu_cleanup_mapping(struct virtio_gpu_simple_resource *res)
{
virtio_gpu_cleanup_mapping_iov(res->iov, res->iov_cnt);
- g_free(res->iov);
res->iov = NULL;
res->iov_cnt = 0;
}
--
1.8.3.1
- [Qemu-devel] [PULL 00/11] virtio-gpu+gtk: add 3d rendering support, Gerd Hoffmann, 2015/10/10
- [Qemu-devel] [PULL 08/11] virtio-gpu: add cursor update tracepoint, Gerd Hoffmann, 2015/10/09
- [Qemu-devel] [PULL 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 06/11] virtio-gpu: update headers for virgl/3d, Gerd Hoffmann, 2015/10/09
- [Qemu-devel] [PULL 10/11] gtk/opengl: add opengl context and scanout support (egl), Gerd Hoffmann, 2015/10/09
- [Qemu-devel] [PULL 07/11] virtio-gpu: add 3d mode and virgl rendering support., Gerd Hoffmann, 2015/10/09
- [Qemu-devel] [PULL 02/11] sdl2: stop flickering, Gerd Hoffmann, 2015/10/09
- [Qemu-devel] [PULL 05/11] virtio-gpu: change licence from GPLv2 to GPLv2+, Gerd Hoffmann, 2015/10/09
- [Qemu-devel] [PULL 09/11] opengl: add egl-context.[ch] helpers, Gerd Hoffmann, 2015/10/09
- [Qemu-devel] [PULL 01/11] shaders: initialize vertexes once, Gerd Hoffmann, 2015/10/09
- [Qemu-devel] [PULL 03/11] ui/console: add opengl context and scanout support interfaces., Gerd Hoffmann, 2015/10/10
- [Qemu-devel] [PULL 11/11] gtk/opengl: add opengl context and scanout support (GtkGLArea), Gerd Hoffmann, 2015/10/10
- Re: [Qemu-devel] [PULL 00/11] virtio-gpu+gtk: add 3d rendering support, Peter Maydell, 2015/10/12