Re: [Qemu-devel] [PULL 00/25] virtio,pc features, fixes

[Peter Maydell]

Adding Marc-André to the cc list since the mail probably hasn't got
through our list server yet...


On 9 October 2015 at 12:05, Peter Maydell <address@hidden> wrote:
> On 8 October 2015 at 22:16, Michael S. Tsirkin <address@hidden> wrote:
>> The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c5816cb:
>>
>>   Merge remote-tracking branch 
>> 'remotes/awilliam/tags/vfio-update-20151007.0' into staging (2015-10-08 
>> 16:50:34 +0100)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>>
>> for you to fetch changes up to 530ec3c089f7544428e0be68c24b527073192cf1:
>>
>>   intel_iommu: Add support for translation for devices behind bridges 
>> (2015-10-08 23:59:51 +0300)
>>
>> ----------------------------------------------------------------
>> virtio,pc features, fixes
>>
>> New features:
>>     vhost-user migration support
>>     VT-d support for devices behind a bridge
>>
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
>
> I'm afraid this fails to build on OSX:
>
> /Users/pm215/src/qemu-for-merges/util/memfd.c:81:34: error: use of
> undeclared identifier 'MFD_ALLOW_SEALING'
>         mfd = memfd_create(name, MFD_ALLOW_SEALING | MFD_CLOEXEC);
>                                  ^
> /Users/pm215/src/qemu-for-merges/util/memfd.c:81:54: error: use of
> undeclared identifier 'MFD_CLOEXEC'
>         mfd = memfd_create(name, MFD_ALLOW_SEALING | MFD_CLOEXEC);
>                                                      ^
> /Users/pm215/src/qemu-for-merges/util/memfd.c:86:34: error: use of
> undeclared identifier 'MFD_CLOEXEC'
>         mfd = memfd_create(name, MFD_CLOEXEC);
>                                  ^
> /Users/pm215/src/qemu-for-merges/util/memfd.c:91:13: warning: implicit
> declaration of function 'ftruncate' is invalid in C99
> [-Wimplicit-function-declaration]
>         if (ftruncate(mfd, size) == -1) {
>             ^
> /Users/pm215/src/qemu-for-merges/util/memfd.c:93:13: warning: implicit
> declaration of function 'close' is invalid in C99
> [-Wimplicit-function-declaration]
>             close(mfd);
>             ^
> /Users/pm215/src/qemu-for-merges/util/memfd.c:108:9: warning: implicit
> declaration of function 'unlink' is invalid in C99
> [-Wimplicit-function-declaration]
>         unlink(fname);
>         ^
> 3 warnings and 3 errors generated.
>
>
> and also on AArch64 Linux:
>
> /home/petmay01/qemu/util/memfd.c: In function ‘memfd_create’:
> /home/petmay01/qemu/util/memfd.c:57:20: error: ‘__NR_memfd_create’
> undeclared (first use in this function)
>      return syscall(__NR_memfd_create, name, flags);
>                     ^
> /home/petmay01/qemu/util/memfd.c:57:20: note: each undeclared
> identifier is reported only once for each function it appears in
> /home/petmay01/qemu/util/memfd.c:58:1: error: control reaches end of
> non-void function [-Werror=return-type]
>  }
>  ^
> cc1: all warnings being treated as errors
>
> thanks
> -- PMM

-- PMM