[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 23/51] ivshmem: use common is_power_of_2()
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PULL v3 23/51] ivshmem: use common is_power_of_2() |
Date: |
Tue, 13 Oct 2015 16:25:50 +0200 |
From: Marc-André Lureau <address@hidden>
The common version correctly checks for 0 value case.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Claudio Fontana <address@hidden>
---
hw/misc/ivshmem.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index fbb6f40..e678b18 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -117,10 +117,6 @@ static inline uint32_t ivshmem_has_feature(IVShmemState
*ivs,
return (ivs->features & (1 << feature));
}
-static inline bool is_power_of_two(uint64_t x) {
- return (x & (x - 1)) == 0;
-}
-
/* accessing registers - based on rtl8139 */
static void ivshmem_update_irq(IVShmemState *s)
{
@@ -632,7 +628,7 @@ static uint64_t ivshmem_get_size(IVShmemState * s, Error
**errp) {
}
/* BARs must be a power of 2 */
- if (!is_power_of_two(value)) {
+ if (!is_power_of_2(value)) {
error_setg(errp, "size must be power of 2");
return 0;
}
--
2.4.3
- [Qemu-devel] [PULL v3 06/51] ivshmem: factor out the incoming fifo handling, (continued)
- [Qemu-devel] [PULL v3 06/51] ivshmem: factor out the incoming fifo handling, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 08/51] ivshmem: remove superflous ivshmem_attr field, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 09/51] ivshmem: remove useless doorbell field, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 07/51] ivshmem: remove unnecessary dup(), marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 10/51] ivshmem: more qdev conversion, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 11/51] ivshmem: remove last exit(1), marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 15/51] ivshmem: remove useless ivshmem_update_irq() val argument, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 18/51] ivshmem: improve debug messages, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 17/51] ivshmem: remove max_peer field, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 21/51] ivshmem: simplify a bit the code, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 23/51] ivshmem: use common is_power_of_2(),
marcandre . lureau <=
- [Qemu-devel] [PULL v3 22/51] ivshmem: use common return, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 19/51] ivshmem: improve error handling, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 25/51] ivshmem: shmfd can be 0, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 20/51] ivshmem: print error on invalid peer id, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 26/51] ivshmem: check shm isn't already initialized, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 24/51] ivshmem: migrate with VMStateDescription, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 28/51] ivshmem: fix pci_ivshmem_exit(), marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 31/51] ivshmem: reset mask on device reset, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 35/51] ivshmem-server: use a uint16 for client ID, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 29/51] ivshmem: replace 'guest' for 'peer' appropriately, marcandre . lureau, 2015/10/13