|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test |
Date: | Wed, 14 Oct 2015 07:44:00 +1100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 10/14/2015 12:40 AM, Sergey Fedorov wrote:
Otherwise, "!(tb_end <= start || tb_start >= end)" condition check will fail
...
So we either need to change the condition in tb_invalidate_phys_page_range() or do the PC advancement trick during translation, no matter can instructions cross a page boundary or not.
I think you're right.The reason I've not seen an issue so far is that breakpoint_invalidate expands the requested range to the entire page. So the failure to invalidate would require the breakpoint to be at the page boundary.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |