[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 08/18] qapi: Lazy creation of array types
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v8 08/18] qapi: Lazy creation of array types |
Date: |
Wed, 14 Oct 2015 06:57:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/14/2015 01:15 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> Commit ac88219a had several TODO markers about whether we needed
>> to automatically create the corresponding array type alongside
>> any other type. It turns out that most of the time, we don't!
>>
>> As part of lazy creation of array types, this patch now assigns
>> an 'info' to array types at their point of first instantiation,
>> rather than leaving it None.
>
> I'm afraid this flips the value of .is_implicit() to False. Currently
> harmless, but let's keep it correct anyway.
>
> The obvious fix is to define the trivial override method:
>
> def is_implicit(self):
> return True
>
> But I'd rather do *all* the "give implicit types info" work in "qapi:
> Track location that created an implicit type", i.e. move the plumbing of
> info there, add the override method there, drop the "As part of"
> paragraph from the commit message here. I append what's left of this
> patch then. I like it, because the patch that actually changes
> generated code (this one) becomes really simple, and the lengthened
> patch remains mere info-plumbing that doesn't affect the generated code.
Makes sense, so I agree with how you've redone the current state of
qapi-next.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v8 00/18] post-introspection cleanups, subset B, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 03/18] qapi: Drop redundant alternate-good test, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 04/18] qapi: Move empty-enum to compile-time test, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 05/18] qapi: Drop redundant returns-int test, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 01/18] qapi: Use predicate callback to determine visit filtering, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 07/18] qapi: Don't use info as witness of implicit object type, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 08/18] qapi: Lazy creation of array types, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 14/18] qapi: Detect collisions in C member names, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 11/18] qapi: Simplify gen_struct_field(), Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 09/18] qapi: Create simple union type member earlier, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 12/18] qapi: Track location that created an implicit type, Eric Blake, 2015/10/13
- [Qemu-devel] [PATCH v8 10/18] qapi: Move union tag quirks into subclass, Eric Blake, 2015/10/13