[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakp
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint |
Date: |
Fri, 16 Oct 2015 08:33:01 +0100 |
On 16 October 2015 at 02:14, Richard Henderson <address@hidden> wrote:
> Heh. Fair enough. How about
>
> /* The address covered by the breakpoint must be included in
> [tb->pc, tb->pc + tb->size) in order to for it to be
> properly cleared -- thus we increment the PC here so that
> the logic setting tb->size below does the right thing. */
>
> There are two edge cases that cause the problem with clearing that could be
> described, but I think that the comment becomes too bulky, as well as
> confuses the situation for someone cutting-and-pasting the logic to a new
> port.
OK, that sounds good. (It does suggest that we should just be
advancing PC by 1 for all targets, though.)
-- PMM
- [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Richard Henderson, 2015/10/15
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Sergey Fedorov, 2015/10/14
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Peter Maydell, 2015/10/14
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Richard Henderson, 2015/10/15
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Peter Maydell, 2015/10/15
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Richard Henderson, 2015/10/15
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Sergey Fedorov, 2015/10/16
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Sergey Fedorov, 2015/10/16
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Sergey Fedorov, 2015/10/16
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Richard Henderson, 2015/10/18
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Sergey Fedorov, 2015/10/19
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Richard Henderson, 2015/10/19
- Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint, Sergey Fedorov, 2015/10/19