[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/7] net: don't set native endianness
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 3/7] net: don't set native endianness |
Date: |
Fri, 16 Oct 2015 11:49:23 +0300 |
commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991
vhost-net: tell tap backend about the vnet endianness
makes vhost net always try to set LE - even if that matches the
native endian-ness.
This makes it fail on older kernels on x86 without TUNSETVNETLE support.
To fix, make qemu_set_vnet_le/qemu_set_vnet_be skip the
ioctl if it matches the host endian-ness.
Reported-by: Marcel Apfelbaum <address@hidden>
Cc: Greg Kurz <address@hidden>
Cc: address@hidden
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
---
net/net.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/net/net.c b/net/net.c
index 28a5597..8e96011 100644
--- a/net/net.c
+++ b/net/net.c
@@ -517,20 +517,28 @@ void qemu_set_vnet_hdr_len(NetClientState *nc, int len)
int qemu_set_vnet_le(NetClientState *nc, bool is_le)
{
+#ifdef HOST_WORDS_BIGENDIAN
if (!nc || !nc->info->set_vnet_le) {
return -ENOSYS;
}
return nc->info->set_vnet_le(nc, is_le);
+#else
+ return 0;
+#endif
}
int qemu_set_vnet_be(NetClientState *nc, bool is_be)
{
+#ifdef HOST_WORDS_BIGENDIAN
+ return 0;
+#else
if (!nc || !nc->info->set_vnet_be) {
return -ENOSYS;
}
return nc->info->set_vnet_be(nc, is_be);
+#endif
}
int qemu_can_send_packet(NetClientState *sender)
--
MST
- [Qemu-devel] [PULL 0/7] vhost, pc features, fixes, Michael S. Tsirkin, 2015/10/16
- [Qemu-devel] [PULL 1/7] intel_iommu: Add support for translation for devices behind bridges, Michael S. Tsirkin, 2015/10/16
- [Qemu-devel] [PULL 2/7] exec: factor out duplicate mmap code, Michael S. Tsirkin, 2015/10/16
- [Qemu-devel] [PULL 3/7] net: don't set native endianness,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 5/7] vhost: add vhost_has_free_slot() interface, Michael S. Tsirkin, 2015/10/16
- [Qemu-devel] [PULL 6/7] pc-dimm: add vhost slots limit check before commiting to hotplug, Michael S. Tsirkin, 2015/10/16
- [Qemu-devel] [PULL 4/7] tests: re-enable vhost-user-test, Michael S. Tsirkin, 2015/10/16
- [Qemu-devel] [PULL 7/7] vhost: fail backend intialization early, Michael S. Tsirkin, 2015/10/16
- Re: [Qemu-devel] [PULL 0/7] vhost, pc features, fixes, Peter Maydell, 2015/10/16