[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] Enable specifying a non-default Hyper-V
|
From: |
Amos Jianjun Kong |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] Enable specifying a non-default Hyper-V vendor ID |
|
Date: |
Sat, 17 Oct 2015 07:06:33 +0800 |
On Sat, Oct 17, 2015 at 2:53 AM, Alex Williamson
<address@hidden> wrote:
> v3: Incorporate suggestion from Igor to move the string length test
> out to the property parsing. A string that's too long will now
> get an error like:
>
> $ qemu-system-x86_64 -cpu qemu64,hv_vendor_id=123456789abcd
> qemu-system-x86_64: Property 'host-x86_64-cpu.hv-vendor-id' doesn't take
> value '123456789abcd'
>
> v2: Remove abort, but truncate string
>
> ---
>
> Alex Williamson (2):
> qapi: Create DEFINE_PROP_STRING_LEN
> kvm: Allow the Hyper-V vendor ID to be specified
Looks good to me.
Reviewed-by: Amos Kong <address@hidden>
>
>
> hw/core/qdev-properties.c | 7 +++++++
> include/hw/qdev-core.h | 1 +
> include/hw/qdev-properties.h | 16 ++++++++++++++--
> target-i386/cpu-qom.h | 1 +
> target-i386/cpu.c | 1 +
> target-i386/kvm.c | 8 +++++++-
> 6 files changed, 31 insertions(+), 3 deletions(-)
>