qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 23/33] nvdimm acpi: init the address region u


From: Xiao Guangrong
Subject: Re: [Qemu-devel] [PATCH v4 23/33] nvdimm acpi: init the address region used by NVDIMM ACPI
Date: Mon, 19 Oct 2015 11:58:35 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0



On 10/19/2015 01:15 AM, Michael S. Tsirkin wrote:
On Mon, Oct 19, 2015 at 08:54:09AM +0800, Xiao Guangrong wrote:
+typedef struct nfit_spa nfit_spa;

There are still multiple coding style violations.  Pls fix all code to
match coding style.  I commented on this before.


Er, i thought what you disliked is just function names... Now I know i
was misunderstanding it and sorry for wasting your time on it.

I will change all structs in this patch that:
struct nfit_spa -> struct nvdimm_nfit_spa
struct nfit_memdev -> struct nvdimm_nfit_memdev
struct nfit_dcr nfit_dcr -> struct nvdimm_nfit_dcr nfit_dcr;

and also copy the spec reference from where these struct was used to
where these struct was defined.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]