Re: [Qemu-devel] [PATCH] qapi: Adding websocket information inside VncInfo structure.

[Julio Faracco]

Thanks Erik and Gerd for you feedback...

I will rebase the changes consider the opinions...
I agree about VncInfo2... because some structures are ready to use,
including websocket.
Without adding new fields or other changes.

Julio Cesar Faracco


2015-10-19 6:17 GMT-02:00 Gerd Hoffmann <address@hidden>:
>   Hi,
>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index a386605..e97f78f 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -916,7 +916,8 @@
>>  { 'struct': 'VncInfo',
>>    'data': {'enabled': 'bool', '*host': 'str',
>>             '*family': 'NetworkAddressFamily',
>> -           '*service': 'str', '*auth': 'str', '*clients': 
>> ['VncClientInfo']} }
>> +           '*service': 'str', '*auth': 'str', '*clients': ['VncClientInfo'],
>> +           '*webservice': 'str', 'has_websocket': 'bool'} }
>>
>>  ##
>>  # @VncPriAuth:
>
> Please leave VncInfo alone.  There is VncInfo2 which should fill all
> your needs.
>
> You might consider switching hmp_info_vnc() to use the new
> qmp_query_vnc_servers() instead of the old qmp_query_vnc().
>
> cheers,
>   Gerd
>
>