[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qxl: lock current_async update in qxl_soft_rese
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] qxl: lock current_async update in qxl_soft_reset |
|
Date: |
Tue, 20 Oct 2015 14:13:50 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 20/10/2015 09:58, Gerd Hoffmann wrote:
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/display/qxl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 9c961da..20dc72e 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1156,7 +1156,9 @@ static void qxl_soft_reset(PCIQXLDevice *d)
> trace_qxl_soft_reset(d->id);
> qxl_check_state(d);
> qxl_clear_guest_bug(d);
> + qemu_mutex_lock(&d->async_lock);
> d->current_async = QXL_UNDEFINED_IO;
> + qemu_mutex_unlock(&d->async_lock);
>
> if (d->id == 0) {
> qxl_enter_vga_mode(d);
>
Thanks, this should fix a defect report from Coverity.
Reviewed-by: Paolo Bonzini <address@hidden>