[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname,

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path]
Date: Wed, 21 Oct 2015 07:58:26 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 10/21/2015 07:34 AM, Prasanna Kumar Kalever wrote:

Missing a 0/3 cover letter; you may want to do:

git config format.coverLetter auto

so that you don't forget it next time.

> it will be quite messy to have colliding names for variables, so to maintain
> better readability and make it consistent with other existing code as well as
> the input keys/options which will be introduced by next couple of patches, 
> this
> patch renames the following variables
> 'server'  -> 'host'
> 'image'   -> 'path'
> 'volname' -> 'volume'
> Signed-off-by: Prasanna Kumar Kalever <address@hidden>
> ---
>  block/gluster.c | 54 +++++++++++++++++++++++++++---------------------------
>  1 file changed, 27 insertions(+), 27 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]