Re: [Qemu-devel] [PATCH] hw/arm/virt: Fix address in PCIe device tree node's unit name

[Alexander Gordeev]

On Wed, Oct 21, 2015 at 10:26:27PM +0100, Peter Maydell wrote:
> On 21 October 2015 at 21:43, Alexander Gordeev <address@hidden> wrote:
> > PCIe device tree unit name is address@hidden - which denotes
> > IO space base address. However, the corresponding node's
> > "reg" property points to PCI configuration space base address
> > 0x3f000000.
> >
> > Set the unit name to address@hidden which is not only correct,
> > but also conforms to Open Firmware (IEEE 1275).
> 
> Nothing should actually care about the address in the
> nodename, though, right -- it's just for human readability
> and debugging (and guests will be looking at the regs
> etc properties of the node to figure out where it is)?
> Or have I misunderstood this and there's an actual visible
> consequence to this bug?

I do not think there are actual consequences out there.
It is just misleading and does not honour the standard.

> thanks
> -- PMM

-- 
Regards,
Alexander Gordeev
address@hidden