[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/10] net: Remove duplicate data from query-rx-filte
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 08/10] net: Remove duplicate data from query-rx-filter on multiqueue net devices |
Date: |
Tue, 27 Oct 2015 14:08:42 +0800 |
From: Vladislav Yasevich <address@hidden>
When responding to a query-rx-filter command on a multiqueue
netdev, qemu reports the data for each queue. The data, however,
is not per-queue, but per device and the same data is reported
multiple times. This causes confusion and may also cause extra
unnecessary processing when looking at the data.
Commit 638fb14169 (net: Make qmp_query_rx_filter() with name argument
more obvious) partially addresses this issue, by limiting the output
when the name is specified. However, when the name is not specified,
the issue still persists.
Signed-off-by: Vladislav Yasevich <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
net/net.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/net/net.c b/net/net.c
index 3c68f3f..70a3576 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1227,6 +1227,12 @@ RxFilterInfoList *qmp_query_rx_filter(bool has_name,
const char *name,
continue;
}
+ /* only query information on queue 0 since the info is per nic,
+ * not per queue
+ */
+ if (nc->queue_index != 0)
+ continue;
+
if (nc->info->query_rx_filter) {
info = nc->info->query_rx_filter(nc);
entry = g_malloc0(sizeof(*entry));
--
2.1.4
- [Qemu-devel] [PULL 00/10] Net patches, Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 01/10] net: cadence_gem: Set initial MAC address, Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 02/10] net/dump: Add support for receive_iov function, Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 03/10] net/dump: Rework net-dump init functions, Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 04/10] net/dump: Separate the NetClientState from the DumpState, Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 06/10] options: Add documentation for filter-dump, Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 05/10] net/dump: Provide the dumping facility as a net-filter, Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 07/10] vmxnet3: Do not fill stats if device is inactive, Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 08/10] net: Remove duplicate data from query-rx-filter on multiqueue net devices,
Jason Wang <=
- [Qemu-devel] [PULL 09/10] net: make iov_to_buf take right size argument in nc_sendv_compat(), Jason Wang, 2015/10/27
- [Qemu-devel] [PULL 10/10] net: free the string returned by object_get_canonical_path_component, Jason Wang, 2015/10/27
- Re: [Qemu-devel] [PULL 00/10] Net patches, Peter Maydell, 2015/10/27