[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 02/11] vl.c: Use error_report() when reporting sh
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH v3 02/11] vl.c: Use error_report() when reporting shutdown signal |
Date: |
Fri, 30 Oct 2015 13:07:53 -0200 |
This usage of fprintf(stderr) can't be directly converted to
error_report() like the others, because a single error message is split
into multiple fprintf() calls. Make separate error_report() calls for
each case.
Suggested-by: Markus Armbruster <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
vl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index 4ee460f..447cb9a 100644
--- a/vl.c
+++ b/vl.c
@@ -1626,14 +1626,14 @@ static int qemu_shutdown_requested(void)
static void qemu_kill_report(void)
{
if (!qtest_driver() && shutdown_signal != -1) {
- fprintf(stderr, "qemu: terminating on signal %d", shutdown_signal);
if (shutdown_pid == 0) {
/* This happens for eg ^C at the terminal, so it's worth
* avoiding printing an odd message in that case.
*/
- fputc('\n', stderr);
+ error_report("terminating on signal %d", shutdown_signal);
} else {
- fprintf(stderr, " from pid " FMT_pid "\n", shutdown_pid);
+ error_report("terminating on signal %d from pid " FMT_pid,
+ shutdown_signal, shutdown_pid);
}
shutdown_signal = -1;
}
--
2.1.0
- [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework, Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 02/11] vl.c: Use error_report() when reporting shutdown signal,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v3 01/11] vl.c: Replace fprintf(stderr) with error_report(), Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 03/11] vl.c: Remove periods and exclamation points from error messages, Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 04/11] vl.c: Use "warning:" prefix consistently on warnings, Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 05/11] vl.c: Use "cannot" instead of "can not" in error messages, Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 06/11] vl.c: Use 'quotes' instead of `quotes' in messages, Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 08/11] vl.c: Change "fail to parse" error message to "failed to parse", Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 07/11] vl.c: Remove unnecessary uppercase in error messages, Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 09/11] vl.c: Simplify "ignoring deprecated option" warnings, Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 11/11] vl.c: Use "%s support is disabled" error messages consistently, Eduardo Habkost, 2015/10/30
- [Qemu-devel] [PATCH v3 10/11] vl.c: Reword -no-kvm-pit-reinjection deprecation warning, Eduardo Habkost, 2015/10/30