qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework
Date: Fri, 30 Oct 2015 15:31:58 -0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Oct 30, 2015 at 01:07:51PM -0200, Eduardo Habkost wrote:
> Changes v2 -> v3:
> * Removed patch: "vl.c: Convert error sentences to simpler phrases"
> * Removed patch: "vl.c: Reword -machine help error messages"
> * Removed patch: "vl.c: Reword fw_cfg name prefix warning"
> * Removed patch: "vl.c: Use US spelling for 'unrecognized'"
> * New patch: "vl.c: Change 'fail to parse' error message to 'failed to parse'"
> * Squashed "vl.c: trivial: Don't wrap lines unnecessarily"
>   into "vl.c: Replace fprintf(stderr) with error_report()"

Forgot to include this on changelog:

* vl.c: Replace fprintf(stderr) with error_report():
  * Don't include newlines on error_report() strings
    Reported-by: Markus Armbruster <address@hidden>
  * Break a few long lines
* vl.c: Remove periods and exclamation points from error messages
  * Remove exclamation points from some messages too
  * Fix "No machine specified, and there is no default" message, too
* vl.c: Remove unnecessary uppercase in error messages
  * Converted two additional cases in the same patch:
    "Cannot initialize crypto" and "curses support is disabled"
* vl.c: Simplify "ignoring deprecated option" warnings
  * No need to mention option name in error message, as it is already
    present in the prefix printed by error_report()
* vl.c: Reword -no-kvm-pit-reinjection deprecation warning
  * No need to mention option name in error message, as it is already
    present in the prefix printed by error_report()
* vl.c: Use "%s support is disabled" error messages consistently
  * Use "support is disabled" instead of "support disabled"

> 
> Changes v1 -> v2:
> * Extra patches for many suggestions I got when changing vl.c to use
>   error_report()
> 
> Eduardo Habkost (11):
>   vl.c: Replace fprintf(stderr) with error_report()
>   vl.c: Use error_report() when reporting shutdown signal
>   vl.c: Remove periods and exclamation points from error messages
>   vl.c: Use "warning:" prefix consistently on warnings
>   vl.c: Use "cannot" instead of "can not" in error messages
>   vl.c: Use 'quotes' instead of `quotes' in messages
>   vl.c: Remove unnecessary uppercase in error messages
>   vl.c: Change "fail to parse" error message to "failed to parse"
>   vl.c: Simplify "ignoring deprecated option" warnings
>   vl.c: Reword -no-kvm-pit-reinjection deprecation warning
>   vl.c: Use "%s support is disabled" error messages consistently
> 
>  vl.c | 256 
> +++++++++++++++++++++++++++++++++----------------------------------
>  1 file changed, 125 insertions(+), 131 deletions(-)
> 
> -- 
> 2.1.0
> 

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]