Re: [Qemu-devel] [PATCH v7 0/2] PTimer fix and ARM MPTimer conversion

[Peter Maydell]

On 24 October 2015 at 13:21, Dmitry Osipenko <address@hidden> wrote:
> Changelog for ARM MPTimer QEMUTimer to ptimer conversion:
>
>     V2: Fixed changing periodic timer counter value "on the fly". I added a
>         test to the gist to cover that issue.
>
>     V3: Fixed starting the timer with load = 0 and counter != 0, added tests
>         to the gist for this issue. Changed vmstate version for all VMSD's,
>         since loadvm doesn't check version of nested VMSD.
>
>     V4: Fixed spurious IT bit set for the timer starting in the periodic mode
>         with counter = 0. Test added.
>
>     V5: Code cleanup, now depends on ptimer_set_limit() fix.
>
>     V6: No code change, added test to check ptimer_get_count() with corrected
>         .limit value.
>
>     V7: No change.
>
> ARM MPTimer tests: https://gist.github.com/digetx/dbd46109503b1a91941a

Hi. Given that we're now in the second half of softfreeze, and
the discussions about the design of the changes to ptimer don't
seem to have reached a conclusion yet, I would prefer to defer
this to 2.6. (It feels a bit late in the release cycle to make changes
to a core component like ptimer that affects multiple boards.)
My understanding is that although this patchset fixes a bunch of
edge cases and odd features in the mptimer, there aren't any bugs
that it fixes that cause problems for common guests like Linux, right?

thanks
-- PMM