|
From: | Marcel Apfelbaum |
Subject: | Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices |
Date: | Sun, 1 Nov 2015 11:15:24 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 10/30/2015 05:20 PM, Eduardo Habkost wrote:
On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote: [...]index 095de5d..0a08531 100644 --- a/include/hw/compat.h +++ b/include/hw/compat.h @@ -2,7 +2,51 @@ #define HW_COMPAT_H #define HW_COMPAT_2_4 \ - /* empty */ + {\ + .driver = "virtio-blk-pci",\ + .property = "disable-pcie",\ + .value = "on",\Why not a single virtio-pci.disable-pcie=on entry, instead of one entry for each subclass?
Hi, Thanks for pointing that out, that being said, I am a little embarrassed because I did think of it, but seeing HW_COMPAT 2_3 (any_layout) I assumed this would not work, my bad. By the way, HW_COMPAT_2_3 sets any-layout to off only for a few virtio devices, not for all. Does anybody know if is in purpose or can we do the same for them too? I'll send an updated version shortly, Thanks Marcel
+ },{\ + .driver = "virtio-scsi-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-net-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-input-host-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-keyboard-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-mouse-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-serial-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-tablet-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-gpu-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-balloon-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-rng-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + }, #define HW_COMPAT_2_3 \ {\ -- 2.1.0
[Prev in Thread] | Current Thread | [Next in Thread] |