[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] block: Remove inner quotation marks in i
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] block: Remove inner quotation marks in iotest 085 |
Date: |
Tue, 03 Nov 2015 16:27:20 +0100 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Tue 03 Nov 2015 04:12:44 PM CET, Eric Blake wrote:
> On 11/03/2015 03:32 AM, Alberto Garcia wrote:
>> This patch removes the inner quotation marks in all cases like this:
>>
>> cmd=" ... "${variable}" ... "
>>
>> Signed-off-by: Alberto Garcia <address@hidden>
>> ---
>> tests/qemu-iotests/085 | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> I might have worded the commit message differently, though:
>
> block: Remove incorrect "" in iotest 085
>
> We had the patterns:
> cmd="..."${variable}"..."
> _send_qemu_cmd ... "..."${variable}"..."
>
> which is equivalent to using ${variable} unquoted. In the cmd= usage,
> that happened to be okay even though it is unusual (because no word
> splitting occurs on variable assignment); but where the usage appeared
> as an argument to _send_qemu_cmd, it was actively wrong (any whitespace
> in ${variable} would have caused word splitting).
You're right, I overlooked the _send_qemu_cmd case !
I'll rewrite the message if there's a new version of the series.
Berto