Re: [Qemu-devel] [Qemu-block] [PATCH v10 03/14] block: rename BlkTransactionState and BdrvActionOps

[Jeff Cody]

On Fri, Oct 23, 2015 at 07:56:41PM -0400, John Snow wrote:
> These structures are misnomers, somewhat.
> 
> (1) BlockTransactionState is not state for a transaction,
>     but is rather state for a single transaction action.
>     Rename it "BlkActionState" to be more accurate.
> 
> (2) The BdrvActionOps describes operations for the BlkActionState,
>     above. This name might imply a 'BdrvAction' or a 'BdrvActionState',
>     which there isn't.
>     Rename this to 'BlkActionOps' to match 'BlkActionState'.
> 
> Lastly, update the surrounding in-line documentation and comments
> to reflect the current nature of how Transactions operate.
> 
> This patch changes only comments and names, and should not affect
> behavior in any way.
> 
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  blockdev.c | 116 
> ++++++++++++++++++++++++++++++++++---------------------------
>  1 file changed, 65 insertions(+), 51 deletions(-)
> 
 
just a heads up - this patch fails to apply on qemu master, so a
rebase is probably in order (this series is based on qemu master,
right?)

(I'll review from your github branch for now)