[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev |
Date: |
Thu, 5 Nov 2015 17:21:59 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/05/2015 04:52 PM, Wen Congyang wrote:
> On 11/05/2015 03:43 PM, zhanghailiang wrote:
>> > Hi Jason,
>> >
>> > On 2015/11/4 10:56, Jason Wang wrote:
>>> >>
>>> >>
>>> >> On 11/03/2015 07:56 PM, zhanghailiang wrote:
>>>> >>> Signed-off-by: zhanghailiang <address@hidden>
>>>> >>> Cc: Jason Wang <address@hidden>
>>> >>
>>> >> Commit log please.
>>> >>
>>>> >>> ---
>>>> >>> v10: new patch
>>>> >>> ---
[...]
>>>> >>> +}
>>>> >>> +/*
>>>> >>> +* This will be used by COLO or MC FT, for which they will need
>>>> >>> +* to buffer all the packets of all VM's net devices, Here we check
>>>> >>> +* and automatically add netfilter for netdev that doesn't attach any
>>>> >>> buffer
>>>> >>> +* netfilter.
>>>> >>> +*/
>>>> >>> +void qemu_auto_add_filter_buffer(NetFilterDirection direction, Error
>>>> >>> **errp)
>>>> >>> +{
>>>> >>> + char *queue = g_strdup(NetFilterDirection_lookup[direction]);
>>>> >>> +
>>>> >>> + qemu_foreach_netdev(netdev_add_filter_buffer, queue,
>>>> >>> + errp);
>>>> >>> + g_free(queue);
>>>> >>> +}
>>>> >>> +
>>> >>
>>> >> This make me think for following questions:
>>> >>
>>> >> - What if a nic is hot added after this "automatically" filter add?
> IIRC, we don't allow the user to hotplug a device when colo is running.
>
> Thanks
> Wen Congyang
>
Even in the future? And how could forbid the user to do this, management?
Thanks
- [Qemu-devel] [PATCH COLO-Frame v10 24/38] COLO failover: Shutdown related socket fd when do failover, (continued)
- [Qemu-devel] [PATCH COLO-Frame v10 24/38] COLO failover: Shutdown related socket fd when do failover, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 29/38] savevm: Split load vm state function qemu_loadvm_state, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 37/38] colo: Use the netfilter to buffer and release packets, zhanghailiang, 2015/11/03
- [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev, zhanghailiang, 2015/11/03
- Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev, Jason Wang, 2015/11/05
- Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev, zhanghailiang, 2015/11/05
[Qemu-devel] [PATCH COLO-Frame v10 33/38] netfilter: Introduce an API to delete the timer of all buffer-filters, zhanghailiang, 2015/11/03
[Qemu-devel] [PATCH COLO-Frame v10 26/38] COLO: Control the checkpoint delay time by migrate-set-parameters command, zhanghailiang, 2015/11/03