[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v9 21/56] migration_is_setup_or_active
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PATCH v9 21/56] migration_is_setup_or_active |
Date: |
Thu, 5 Nov 2015 18:10:48 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
Add 'migration_is_setup_or_active' utility function to check state.
(It gets postcopy added to it's list later on in the series)
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/migration.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 8380e2f..4317bab 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -444,6 +444,23 @@ MigrationParameters *qmp_query_migrate_parameters(Error
**errp)
return params;
}
+/*
+ * Return true if we're already in the middle of a migration
+ * (i.e. any of the active or setup states)
+ */
+static bool migration_is_setup_or_active(int state)
+{
+ switch (state) {
+ case MIGRATION_STATUS_ACTIVE:
+ case MIGRATION_STATUS_SETUP:
+ return true;
+
+ default:
+ return false;
+
+ }
+}
+
static void get_xbzrle_cache_stats(MigrationInfo *info)
{
if (migrate_use_xbzrle()) {
@@ -551,8 +568,7 @@ void
qmp_migrate_set_capabilities(MigrationCapabilityStatusList *params,
MigrationState *s = migrate_get_current();
MigrationCapabilityStatusList *cap;
- if (s->state == MIGRATION_STATUS_ACTIVE ||
- s->state == MIGRATION_STATUS_SETUP) {
+ if (migration_is_setup_or_active(s->state)) {
error_setg(errp, QERR_MIGRATION_ACTIVE);
return;
}
@@ -682,8 +698,7 @@ static void migrate_fd_cancel(MigrationState *s)
do {
old_state = s->state;
- if (old_state != MIGRATION_STATUS_SETUP &&
- old_state != MIGRATION_STATUS_ACTIVE) {
+ if (!migration_is_setup_or_active(old_state)) {
break;
}
migrate_set_state(s, old_state, MIGRATION_STATUS_CANCELLING);
@@ -815,8 +830,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
params.blk = has_blk && blk;
params.shared = has_inc && inc;
- if (s->state == MIGRATION_STATUS_ACTIVE ||
- s->state == MIGRATION_STATUS_SETUP ||
+ if (migration_is_setup_or_active(s->state) ||
s->state == MIGRATION_STATUS_CANCELLING) {
error_setg(errp, QERR_MIGRATION_ACTIVE);
return;
--
2.5.0
- [Qemu-devel] [PATCH v9 13/56] migrate_init: Call from savevm, (continued)
- [Qemu-devel] [PATCH v9 13/56] migrate_init: Call from savevm, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 16/56] Return path: Open a return path on QEMUFile for sockets, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 15/56] Add Linux userfaultfd.h header, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 14/56] Rename save_live_complete to save_live_complete_precopy, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 17/56] Return path: socket_writev_buffer: Block even on non-blocking fd's, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 18/56] Migration commands, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 19/56] Return path: Control commands, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 20/56] Return path: Send responses from destination to source, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 21/56] migration_is_setup_or_active,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PATCH v9 22/56] Return path: Source handling of return path, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 23/56] Rework loadvm path for subloops, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 24/56] Add migration-capability boolean for postcopy-ram., Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 25/56] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages., Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 26/56] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 27/56] Modify save_live_pending for postcopy, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 30/56] migration_completion: Take current state, Dr. David Alan Gilbert (git), 2015/11/05
- [Qemu-devel] [PATCH v9 28/56] postcopy: OS support test, Dr. David Alan Gilbert (git), 2015/11/05