|
From: | zhanghailiang |
Subject: | Re: [Qemu-devel] [PATCH COLO-Frame v10 01/38] configure: Add parameter for configure to enable/disable COLO support |
Date: | Fri, 6 Nov 2015 15:36:21 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
Hi Eric, On 2015/11/5 22:52, Eric Blake wrote:
On 11/03/2015 04:56 AM, zhanghailiang wrote:configure --enable-colo/--disable-colo to switch COLO support on/off. COLO support is off by default.Off by default risks bit-rot for people not building it; it's generally best to default to off only if the feature requires dragging in extra libraries or similar build items not likely to be present in all development environments (and even then, auto-probing for required prerequisites is nicer than hard-coding off). Would on-by-default be a saner choice, or would that drag in too many extra dependencies for building?
In old version, which uses kernel proxy, we have to install relevant nfnetlink libraries. For the new version, we have dropped kernel proxy, so it is OK to turn it On by default. I will fix it in next version :) Thanks, zhanghailiang
[Prev in Thread] | Current Thread | [Next in Thread] |