[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] s390: Allow hotplug of s390 CPUs
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] s390: Allow hotplug of s390 CPUs |
Date: |
Mon, 9 Nov 2015 16:56:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
Am 09.11.2015 um 16:37 schrieb Christian Borntraeger:
> Am 09.11.2015 um 16:35 schrieb Christian Borntraeger:
>> Am 09.11.2015 um 16:28 schrieb Andreas Färber:
>>> Hi,
>>>
>>> Am 09.11.2015 um 16:17 schrieb Matthew Rosato:
>>>> To subsequently hotplug a CPU:
>>>>
>>>> Issue 'cpu-add <id>' from qemu monitor, or use virsh setvcpus --count <n>
>>>> <domain>, where <n> is the total number of desired guest CPUs.
>>>
>>> What exactly is still missing for you to use the standard device_add?
>>>
>>> Last time I checked (a while ago...) some patches were stuck on the x86
>>> side, and I don't recall hearing any feedback from the s390x side in my
>>> KVM Forum CPU hotplug session.
>>
>> libvirt uses "cpu-add" unconditionally for hotplugging, so we certainly
>> want to support that.
>
> Sorry, hit send too early. I assume you want us to support device_add of
> a CPU in addition to that. Correct?
No, I mean as I've always said: cpu-add was a short-term hack to make
CPU hotplug work on x86. libvirt certainly needs to be fixed if it
assumes this to work for s390.
If device_add works, we don't need cpu-add. If device_add does not work,
we need to know which patches are missing. device_del is a separate
beast and there were also patches around that seemed incomplete
according to Eduardo.
Bharata did implement device_add for pseries, I thought.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH 0/4] s390: Allow hotplug of s390 CPUs, Matthew Rosato, 2015/11/09
- [Qemu-devel] [PATCH 1/4] s390x/cpu: Cleanup init in preparation for hotplug, Matthew Rosato, 2015/11/09
- [Qemu-devel] [PATCH 2/4] s390x/cpu: Set initial CPU state in common routine, Matthew Rosato, 2015/11/09
- [Qemu-devel] [PATCH 3/4] s390x/cpu: Add function to set CPU state, Matthew Rosato, 2015/11/09
- [Qemu-devel] [PATCH 4/4] s390x/cpu: Allow hotplug of CPUs, Matthew Rosato, 2015/11/09
- Re: [Qemu-devel] [PATCH 0/4] s390: Allow hotplug of s390 CPUs, Andreas Färber, 2015/11/09