[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning |
Date: |
Tue, 10 Nov 2015 15:57:35 +0000 |
clang 3.7.0 on x86_64 warns about the following:
disas/arm.c:1782:17: warning: shifting a negative signed value is undefined
[-Wshift-negative-value]
imm |= (-1 << 7);
~~ ^
Note that this patch preserves the tab indent in this source file
because the surrounding code still uses tabs.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
disas/arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/arm.c b/disas/arm.c
index 6165246..7a7354b 100644
--- a/disas/arm.c
+++ b/disas/arm.c
@@ -1779,7 +1779,7 @@ print_insn_coprocessor (bfd_vma pc, struct
disassemble_info *info, long given,
/* Is ``imm'' a negative number? */
if (imm & 0x40)
- imm |= (-1 << 7);
+ imm |= (~0u << 7);
func (stream, "%d", imm);
}
--
2.5.0
- [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PATCH 2/3] tpm: avoid clang shifting negative signed warning, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PATCH 1/3] monitor: avoid clang shifting negative signed warning, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Paolo Bonzini, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Peter Maydell, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Paolo Bonzini, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Markus Armbruster, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Steven Noonan, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Markus Armbruster, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Steven Noonan, 2015/11/10
- Re: [Qemu-devel] [PATCH 3/3] disas/arm: avoid clang shifting negative signed warning, Paolo Bonzini, 2015/11/10
Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning, Peter Maydell, 2015/11/10
Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning, Peter Maydell, 2015/11/16