[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 33/44] block: New option to define the intervals
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PULL 33/44] block: New option to define the intervals for collecting I/O statistics |
Date: |
Wed, 11 Nov 2015 12:10:21 +0100 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Tue 10 Nov 2015 06:23:36 PM CET, Eric Blake <address@hidden> wrote:
>> +# @stats-intervals: #optional colon-separated list of intervals for
>> +# collecting I/O statistics, in seconds (default: none)
>> +# (Since 2.5)
>
> Eww. Sorry for not noticing this sooner, but can we please fix this to
>be:
>
> '*stats-intervals':['int']
No problem, I'll send a follow-up patch asap.
I was actually expecting that there would be some debate about this; in
the series description I mentioned that I considered an alternate API,
although rather than ['int'] it was ['BlockdevStatsInterval'], with
BlockdevStatsInterval being a struct with a sole member 'length': 'int'.
stats-intervals.0.length=60,
stats-intervals.1.length=3600,
stats-intervals.2.length=86400
It's more future proof than just having a list of integers, but I
honestly don't know if there's any use case for additional parameters of
the intervals.
https://lists.gnu.org/archive/html/qemu-block/2015-10/msg01068.html
Berto
- [Qemu-devel] [PULL 27/44] util: Infrastructure for computing recent averages, (continued)
- [Qemu-devel] [PULL 27/44] util: Infrastructure for computing recent averages, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 28/44] block: Add idle_time_ns to BlockDeviceStats, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 30/44] block: Allow configuring whether to account failed and invalid ops, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 29/44] block: Add statistics for failed and invalid I/O operations, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 32/44] block: Add average I/O queue depth to BlockDeviceTimedStats, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 34/44] qemu-io: Account for failed, invalid and flush operations, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 31/44] block: Compute minimum, maximum and average I/O latencies, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 33/44] block: New option to define the intervals for collecting I/O statistics, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 35/44] block: Use QEMU_CLOCK_VIRTUAL for the accounting code in qtest mode, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 37/44] nvme: Account for failed and invalid operations, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 36/44] iotests: Add test for the block device statistics, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 39/44] xen_disk: Account for failed and invalid operations, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 38/44] virtio-blk: Account for failed and invalid operations, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 42/44] macio: Account for failed operations, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 44/44] block: Update copyright of the accounting code, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 40/44] atapi: Account for failed and invalid operations, Stefan Hajnoczi, 2015/11/10
- [Qemu-devel] [PULL 43/44] scsi-disk: Account for failed operations, Stefan Hajnoczi, 2015/11/10