Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

[Paolo Bonzini]

On 16/11/2015 10:48, Andreas Färber wrote:
> > > Thanks! sclp_init() seems to violate several QOM design principles in
> > > that it uses object_new() during TypeInfo::instance_init()
> > 
> > There's nothing wrong with that.  It's wrong however to use
> > qdev_set_parent_bus in instance_init.  That should be moved to
> > sclp_realize, before the realized property is set to true.
> 
> Negative, realize is too late. Since there are two call sites for
> initialization, I don't see a better place for it.

Why is realize too late to set the parent bus?

Paolo