[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target-arm: Update condexec before CP acces
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target-arm: Update condexec before CP access check in AA32 translation |
Date: |
Tue, 17 Nov 2015 13:59:00 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 16.11.2015 22:34, Sergey Fedorov wrote:
> Coprocessor access instructions are allowed inside IT block.
> gen_helper_access_check_cp_reg() can raise an exceptions thus condexec
> bits should be updated before.
>
> Signed-off-by: Sergey Fedorov <address@hidden>
> ---
> target-arm/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 4351854..f1f8129 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -7210,6 +7210,7 @@ static int disas_coproc_insn(DisasContext *s, uint32_t
> insn)
> break;
> }
>
> + gen_set_condexec(dc);
Ah, there must be gen_set_condexec(s).
> gen_set_pc_im(s, s->pc - 4);
> tmpptr = tcg_const_ptr(ri);
> tcg_syn = tcg_const_i32(syndrome);